cleanup: platform: imx8: post-native Zephyr drivers switch cleanup #9077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XTOS is no longer supported on imx8. As a consequence, some calls from imx8's platform_init() have become redundant. Remove these calls/initializations as well as those who are redundant because of some configurations that are not enabled (e.g: `CONFIG_TRACE`, or `CONFIG_HAVE_AGENT`). This is a followup for thesofproject#8863. Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Commit b0cc9dc ("cleanup: platform: imx8: remove redundant calls in platform_init()") removes function call that uses the `timer_shared` structure so it can be dropped. Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
`platform_wait_for_interrupt()` is an XTOS-only construct so it's not needed for imx8 which is a Zephyr-only platform. Remove it. Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Remove unneeded `include` statements. An `include` statement is deemed as unneeded if, by removing it, the build process will not fail. Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
dbaluta
approved these changes
Apr 24, 2024
kv2019i
approved these changes
Apr 24, 2024
|
@wszypelt Hmm, this seems stuck, can you check? |
iuliana-prodan
approved these changes
Apr 25, 2024
dbaluta
approved these changes
Apr 25, 2024
lgirdwood
approved these changes
Apr 25, 2024
|
@wszypelt can you check? we had some stuck PRs cleared today, but this was is still pending. |
|
@kv2019i I ran the tests on this PR again, unfortunately a problem occurred, so I had to add it to the queue again, the results should be available within 40 minutes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.