Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LNL: modular TOML #9105

Merged
merged 2 commits into from
May 9, 2024
Merged

LNL: modular TOML #9105

merged 2 commits into from
May 9, 2024

Conversation

lyakh
Copy link
Collaborator

@lyakh lyakh commented May 7, 2024

No description provided.

lyakh added 2 commits May 7, 2024 15:16
Convert LNL to a modular TOML layout. Many modules have different
configurations for different platforms. In this version we put them
all in respective TOML files directly. If desired, they can be later
extracted into per-platform files. This can be done on a per-module
basis, in which case individual commits will be small.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reduce indentation to match other files.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how the CI fares...

@lyakh
Copy link
Collaborator Author

lyakh commented May 8, 2024

@wszypelt looks like the QB is hanging?

@wszypelt
Copy link

wszypelt commented May 8, 2024

@lyakh new results should be available within an hour

@lyakh
Copy link
Collaborator Author

lyakh commented May 8, 2024

@lyakh new results should be available within an hour

@wszypelt thanks! The results are there but I don't quite like them :-) There's one failure and it's in an up-donw mixer test, i.e. a loadable module, so it sounds "potentially related," but the failure there is with actual audio performance, while this PR only modifies TOML files. Are TOML files used in that test? Maybe LNL TOML files aren't preprocessed for that test?

@lgirdwood
Copy link
Member

@lyakh new results should be available within an hour

@wszypelt thanks! The results are there but I don't quite like them :-) There's one failure and it's in an up-donw mixer test, i.e. a loadable module, so it sounds "potentially related," but the failure there is with actual audio performance, while this PR only modifies TOML files. Are TOML files used in that test? Maybe LNL TOML files aren't preprocessed for that test?

All green now for Internal CI, thanks @wszypelt and @lyakh

@lgirdwood lgirdwood merged commit 0431d2d into thesofproject:main May 9, 2024
41 of 47 checks passed
@lyakh lyakh deleted the lnl branch May 10, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants