Tools: Topology2: Remove unnecessary NHLT binary from EFX topologies #9141
Conversation
The NHLT binary is not needed in these audio processing development and test topologies. With the current build options the NHLT would work only with cAVS2.5 platforms (TGL). Without NHLT add these are safe to use in all platforms where the NHLT blob is retrieved from BIOS. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
| EFX_FIR_PARAMS=passthrough,EFX_IIR_PARAMS=passthrough,\ | ||
| EFX_DRC_COMPONENT=multiband,EFX_MBDRC_PARAMS=passthrough" | ||
|
|
||
| "sof-hda-generic\;sof-hda-efx-mbdrc-generic-4ch\;\ | ||
| HDA_CONFIG=efx,NUM_DMICS=4,PDM1_MIC_A_ENABLE=1,PDM1_MIC_B_ENABLE=1,\ | ||
| PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-hda-efx-generic-4ch.bin,\ |
There was a problem hiding this comment.
This includes PCH DMICs. Don't we need nhlt?
There was a problem hiding this comment.
The blob is needed for DMIC.
There was a problem hiding this comment.
All my test devices have a DMIC NHLT, even UPX has, so I felt this is unnecessary. Also I'm feeling separate builds of these for MTL, LNL, ... is superfluous.
There was a problem hiding this comment.
But it is harmless to build with NHLT, and we will use the NHLT from by default. So, why not to build with NHLT in case any device does not have NHLT?
There was a problem hiding this comment.
this NHLT will only work on cAVS, it is much cleaner if there is no NHLT in tplg than to have arch specific one without spelling out that fact.
| EFX_FIR_PARAMS=passthrough,EFX_IIR_PARAMS=passthrough,\ | ||
| EFX_DRC_COMPONENT=multiband,EFX_MBDRC_PARAMS=passthrough" | ||
|
|
||
| "sof-hda-generic\;sof-hda-efx-mbdrc-generic-4ch\;\ | ||
| HDA_CONFIG=efx,NUM_DMICS=4,PDM1_MIC_A_ENABLE=1,PDM1_MIC_B_ENABLE=1,\ | ||
| PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-hda-efx-generic-4ch.bin,\ |
There was a problem hiding this comment.
The blob is needed for DMIC.
| @@ -60,13 +60,12 @@ NHLT_BIN=nhlt-sof-lnl-nocodec-fpga-4ch.bin,PASSTHROUGH=true,DMIC_IO_CLK=19200000 | |||
| EFX_FIR_PARAMS=passthrough,EFX_IIR_PARAMS=passthrough,EFX_DRC_PARAMS=passthrough" | |||
|
|
|||
| "sof-hda-generic\;sof-hda-efx-generic-2ch\;\ | |||
| HDA_CONFIG=efx,NUM_DMICS=2,PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-hda-fir-generic-2ch.bin,\ | |||
| HDA_CONFIG=efx,NUM_DMICS=2,\ | |||
There was a problem hiding this comment.
ACE platforms can use these with the cAVS blob if they get the NHLT from BIOS, right?
Do we want NHLT in topology for these? To create cAVS and ACE variants with NHLT?
There was a problem hiding this comment.
I don't think there's need to support non-BIOS NHLT with these topologies. If needed occasionally it's very easy to add ourselves for a build.
The NHLT binary is not needed in these audio processing development and test topologies. With the current build options the NHLT would work only with cAVS2.5 platforms (TGL). Without NHLT add these are safe to use in all platforms where the NHLT blob is retrieved from BIOS.