zephyr/cmake: fix llext.uuid growing from the last build #9159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reset the llext.uuid file so it does not start with content from the previous build. Fixes LLEXT incremental builds which apparently never worked (some people like it slow?) Fixes commit 05e69e1 ("llext: update to use add_llext_target()") and the ones before that. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Delete per-platform, "build-sof-staging/sof/intel/sof-ipc4-lib/mtl/" directories every time just like we've always done it for "build-sof-staging/sof/intel/sof-ipc4/mtl/". This is especially important considering the new LLEXT complexity, symbolic links etc. There is no way the build can be smart enough and extend "incremental" builds to the staging directory. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Even with the cryptographic salt, the ability to match a download with the corresponding build log is still useful. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
|
lyakh
approved these changes
May 23, 2024
kv2019i
approved these changes
May 23, 2024
|
Pending pass from mandatory CI jobs, otherwise good to go. |
@wszypelt , @lrudyX can you please re-run https://sof-ci.01.org/sof-pr-viewer/#/build/PR9159/build13991832 where LNL failed with unrelated "connection refused"? This PR should not affect these tests in any way. |
|
@marc-hb all green :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 small LLEXT fixes. Main one:
Reset the llext.uuid file so it does not start with content from the
previous build.
Fixes incremental builds.