ipc: simplify CMakeLists.txt by using a suffix variable #9180
Conversation
zephyr/CMakeLists.txt
Outdated
| ${PROJECT_BINARY_DIR}/src_llext) | ||
| add_dependencies(app src) | ||
| elseif(CONFIG_COMP_SRC) | ||
| zephyr_library_sources( |
There was a problem hiding this comment.
I think this is adding an unrelated change related to llext...
There was a problem hiding this comment.
@kv2019i oh, just a tiny small one, wouldn't hurt! ;-) No, thanks for catching, indeed!
Everywhere, where IPC3 and IPC4 are distinguished in CMakeLists.txt the only difference is the use of x_ipc3.c vs. x_ipc4.c. Instead of duplicating all build instructions for IPC3 and IPC4 just define and use a suffix variable. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
|
SOFCI TEST |
1 similar comment
|
SOFCI TEST |
@marc-hb I don't know but why is this a concern? Would this patch break such cases? |
Yes of course: if it's not tested then it does not work. |
Build test only. |
I haven't tested on target, but from code review and the SOF components we are using with i.MX the changes are ok. |
|
CI failures:
In general, this is a build enhancement, so it is unexpected to introduce subtle run-time failures. |
@marc-hb sorry, not sure I'm getting your answer. My question was, whether this PR was breaking it, not whether it works. |
|
This PR changes "if (IPC3/IPC4)" code in I'm not 100% sure but I think @iuliana-prodan said there is such an active configuration right now. |
Yes, there is. Now, all i.MX is compiled with Zephyr + IPC3. |
Everywhere, where IPC3 and IPC4 are distinguished in CMakeLists.txt the only difference is the use of x_ipc3.c vs. x_ipc4.c. Instead of duplicating all build instructions for IPC3 and IPC4 just define and use a suffix variable.