This fixes a known bug in Firefox #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s normal position after closing the menu
|
HIghly recommended to take this commit |
|
Hi @Zackazt, First of all sorry for the late response. I abandoned this project to have time for my stuff and I'm not proud of that. Second, thank you for the PR! However, I need to ask you. Could you change the css files in Besides, even if I accept the way it is, people won't be able to get the changes because they will compile the CSS all over again and overwrite the file on their machines. Thank you in advance. |
|
Never mind @Zackazt, just pushed a commit to fix that. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a known bug in Firefox that would prevent the header from returning to the normal position after closing the menu.
I simply added a 0.3s transition to .bar-header and set it to left: 15rem when the body has class .push-menu-to-right