Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code <-> Figma sync #65

Open
2 of 8 tasks
JulesKhong opened this issue Feb 27, 2024 · 2 comments
Open
2 of 8 tasks

Code <-> Figma sync #65

JulesKhong opened this issue Feb 27, 2024 · 2 comments
Assignees

Comments

@JulesKhong
Copy link

JulesKhong commented Feb 27, 2024

Depends on #78

Design reviewing Dev

  • Review the base build style guide and site on a multidev to confirm base system is correct. /style-guide @julie-lesseg
  • QA base components
  • Assign priority QA items back to Jules

Dev reviewing Design

  • Review Figma atomic design structure, give feedback to make sure it matches code approach @JulesKhong
  • Ensure figma file is updated with final token values, and naming conventions for typography styles, spacers, grids, and block names. @julie-lesseg @JulesKhong

Design

  • Align on plan for re-org of base build starter file in figma @julie-lesseg
  • Consult design team on proposed changes @julie-lesseg
  • Explore workflow for using base starter file as library or if it's duped for new projects - How are changes captured and documented? @julie-lesseg
@julie-lesseg
Copy link

julie-lesseg commented Apr 25, 2024

@JulesKhong I'm going to use this ticket to track the changes I've made to the figma file that may need to be updated in the code.

So far:

  • Changed text-high-contrast, text-md-contrast, text-low-contrast to text-primary, text-secondary, text-tertiary further separating it from its potential visual display

  • Added two additional large spacer sizes: 7xl and 8xl and wired up this table here to automatically reflect the what's been changed in the variables panel vs what comes standard in base ✨

  • I updated all the color HEX values so might be best to do a pass across all those values 😄

@julie-lesseg
Copy link

UPDATE: Done a full pass over of all the blocks to make sure they are using the dynamic variables that will change on different colorways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants