Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Guide & Demo Site QA #80

Open
14 tasks
julie-lesseg opened this issue Apr 26, 2024 · 0 comments
Open
14 tasks

Style Guide & Demo Site QA #80

julie-lesseg opened this issue Apr 26, 2024 · 0 comments
Assignees

Comments

@julie-lesseg
Copy link

This is my testing page and post: https://dev-ts-base.pantheonsite.io/sample-page/ | https://dev-ts-base.pantheonsite.io/hello-world/

Some of this is config QA and some of it is spacing QA. I've done a complete refresh of the colors and mentioned any and all variable changes in the ticket #65. So perhaps @JulesKhong it makes sense to do a pass over on those first.

Global

  • Adjust button border radius to be 2xs spacing value, currently xs
  • For the demo site, can we load Inter as our font family? I'd be awesome to have more visual alignment with the base build blocks.

Banners

  • Appears to only render the Banner Inset version with the text on top. There is the option to center or have text on left, but there are no other ability to select banner display options.
  • Missing spacing between the image and the text -- should be a 2xl spacer
  • Can we make the description field just a text area rather than a rich text editor? Not all the styles render and I truly don't think there's a need for that much styling ability in this field.

People Cards

  • Getting the error: "This block contains no editable fields. Assign a field group to add fields to this block."

Accordion

News Card Grid

  • Cards are not displaying, both for automatic and for manual curation.
  • There's a bug on the description field that makes the text I'm writing white and not visisble

Image

Wayfinding Cards

Admin side

  • Can we move the toggles after the Block title description and CTA links? At first it wasn't clear to me that these were block heading fields.

Front-End

  • Right now the cards are just stacking and aren't really cards. This might be worth discussing the config we want in the demo site versus what is in the base repo -- I think it'd be nice to show a bit more flexibility on this demo site.

Image + Text Block

  • Gap between image and text content should be 6xl, currently 7xl

Blocks on Posts & Pages

  • All blocks support option for content-width, container-width, and browser width.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants