Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added logic for --copyconfig for systems with only python3 #148

Merged
merged 3 commits into from
Sep 14, 2021

Conversation

m4lwhere
Copy link
Contributor

This change helps systems which only have python3 and not python to copy the initial config file. Without python2's python available on the system, the --copyconfig switch fails to create the working config for the initial run.

@jayjb
Copy link
Contributor

jayjb commented Aug 25, 2021

Hi @m4lwhere,

Thanks for the PR. I see there are a few other changes in the commit as well. Are those intended?

@m4lwhere
Copy link
Contributor Author

Hi @jayjb

Not directly in this commit, this was my first PR I've ever done. 😅

I was planning on submitting those later once I tested the MongoHandler a little more. Would you be interested in me submitting the Mongo Handler once I have the kinks ironed out?

@m4lwhere
Copy link
Contributor Author

m4lwhere commented Sep 6, 2021

Reverted the changes in the second commit, I'll submit a new PR when those are ready

@jayjb jayjb merged commit 0d00368 into thinkst:master Sep 14, 2021
@jayjb
Copy link
Contributor

jayjb commented Sep 14, 2021

Thank you so much for the PR! We really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants