Use sudo only if not running as root #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayjb
requested changes
Jun 23, 2022
There was a problem hiding this comment.
Hi @vin01,
Thanks for submitting a PR. I like the idea of it but currently it breaks with our newly merged PRs.
Basically, we allowing environment variables which are preserved using sudo -E. So as you can probably see, if we remove that sudo, we have have a floating -E.
|
I have updated it @jayjb. Please review. |
jayjb
requested changes
Jun 27, 2022
|
Hi @vin01, Thanks for contributing to the Opencanary project. Please email me at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sudocan be skipped in some cases, like when running in a container as root.Might address #133