Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement allow_blank qualifier to validate_presence_of #1499

Merged

Conversation

andreLumor
Copy link
Contributor

Resolves #1407

allow_blank qualifier for validate_presence_of is now available.
Usage example:

it { is_expected.not_to validate_presence_of(:attribute).allow_blank }

Tests were implemented.

@andreLumor andreLumor force-pushed the feat/validate_presence_of-allow_blank branch from 6170811 to 0d27baf Compare August 4, 2022 20:19
@mcmire
Copy link
Collaborator

mcmire commented Aug 4, 2022

This looks good to me, but waiting until CI passes.

@mcmire mcmire merged commit 7fc812b into thoughtbot:main Aug 5, 2022
@mcmire
Copy link
Collaborator

mcmire commented Aug 5, 2022

Thank you so much @andreLumor!

@vsppedro vsppedro mentioned this pull request Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add allow_blank for validate_presence_of
3 participants