Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Threema Web does not necessarily show number of unread messages #17

Closed
ovalseven8 opened this issue Feb 15, 2017 · 2 comments · Fixed by #211
Closed

Threema Web does not necessarily show number of unread messages #17

ovalseven8 opened this issue Feb 15, 2017 · 2 comments · Fixed by #211
Assignees
@dbrgn
Labels
bug It's a bug!
Milestone
v1.1.1

Comments

@ovalseven8
Copy link
Contributor

ovalseven8 commented Feb 15, 2017 •
edited
Loading

Steps to reproduce:

  1. Open https://web.threema.ch
  2. Write a message to i.e. ECHOECHO
  3. Switch to another (browser) tab immediately
  4. You can see that the tab's title has changed from Threema Web to Threema Web (1). However, because in this tab the chat with ECHOECHO is open, it will be marked as read. So, after about a second you read Threema Web again and you cannot see that you have unread messages. If the chat with ECHOECHO is not open, everything works as expected.

I am not sure if it's technically possible, but messages should only be marked as read when they are really read (in the sense of I look at the chat). Otherwise, I cannot see if I got any message.
@dbrgn dbrgn added the optimization Optimises existing functionality label Feb 15, 2017
@luminatedhorizons
Copy link

Excellent description, thanks for that. Since in this scenario, incoming messages are marked as "read/seen" before even only the tab of Threema Web has been shown on the screen, I would maybe go as far to call this a "bug", no?

@dbrgn dbrgn added bug It's a bug! and removed optimization Optimises existing functionality labels Feb 21, 2017
@ovalseven8 ovalseven8 mentioned this issue Feb 28, 2017
Closed
@dbrgn
Copy link
Contributor

dbrgn commented Mar 7, 2017

To repeat my comment from #108:

Related discussion: thenikso/angular-inview#111

@dbrgn dbrgn self-assigned this Mar 7, 2017
@rugk rugk mentioned this issue Mar 7, 2017
Merged
@dbrgn dbrgn added this to the v1.0.6 milestone Mar 7, 2017
@dbrgn dbrgn modified the milestones: v1.1.1, v1.1.0 Mar 16, 2017
@dbrgn dbrgn mentioned this issue Mar 30, 2017
Open
This was referenced May 2, 2017
Closed
Merged
@dbrgn dbrgn closed this as completed in #211 May 2, 2017
dbrgn pushed a commit that referenced this issue Oct 23, 2018
@threema-danilo
Use document focus instead of page visibility API
02b0927 
For marking messages as unread and for triggering notifications, use
`document.hasFocus()` instead of the page visibility API.

This means that messages are only marked as read if the browser is in
the foreground and focussed. Otherwise, a notification is triggered.

Refs #211 and #17.
dbrgn pushed a commit that referenced this issue Oct 23, 2018
@threema-danilo
Use document focus instead of page visibility API
9c4f2a6 
For marking messages as unread and for triggering notifications, use
`document.hasFocus()` instead of the page visibility API.

This means that messages are only marked as read if the browser is in
the foreground and focussed. Otherwise, a notification is triggered.

Refs #211 and #17.
@dbrgn dbrgn mentioned this issue Oct 23, 2018
Merged
dbrgn added a commit that referenced this issue Oct 23, 2018
@dbrgn
Use document focus instead of page visibility API (#644)
77c50b7 
For marking messages as unread and for triggering notifications, use
`document.hasFocus()` instead of the page visibility API.

This means that messages are only marked as read if the browser is in
the foreground and focussed. Otherwise, a notification is triggered.

Refs #211 and #17.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbrgn dbrgn

Labels
bug It's a bug!
Milestone
v1.1.1
Development

Successfully merging a pull request may close this issue.

Consider page visibility when marking messages as read threema-ch/threema-web
3 participants
@dbrgn @ovalseven8 @luminatedhorizons