Factor analysis and 1D Sample Data #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows generating high dimensional example data which comes from a lower dimensional subspace.
Change names and improve docstrings.
|
Great! This LGTM! Since the factor analysis addition here duplicates your earlier PR, I'll merge this and then we'll close #170? Maybe just update the name and description here to make clear that it includes both changes. |
|
Woops, forgot this would also have the factor analysis commits. Changed the name and description to reflect that. |
|
Ok great, merging in, thanks for the contribution! |
freeman-lab
added a commit
that referenced
this pull request
Apr 17, 2015
Factor analysis and 1D Sample Data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented generation of sample data coming from a factor analysis model.
Changed the sample data keys to make things a bit cleaner.