Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dtype to images.map #285

Merged
merged 6 commits into from
May 9, 2016
Merged

Conversation

boazmohar
Copy link
Contributor

fixes #284
Only adds the functionality for images object not for series.

@boazmohar
Copy link
Contributor Author

Added dtype to series as well.
Something to consider in series.map()
There is currently no way to pass a shape of the resulting index without passing an index. It is an edge case, and I don't know if you want this to be implimented.
@freeman-lab What do you think?

@jwittenbach
Copy link
Contributor

@boazmohar this is looking great. Any chance you could add the same functionality to Blocks.map + a corresponding test? If we can get that in, then I'd be happy to merge this in.

@boazmohar
Copy link
Contributor Author

Sure I will do it later today.

Thanks,
Boaz On Mon, May 09, 2016 at 1:09 PM, Jason Wittenbach < notifications@github.com [notifications@github.com] > wrote:
@boazmohar [https://github.com/boazmohar] this is looking great. Any chance you could add the same functionality to Blocks.map + a corresponding test? If we can get that in, then I'd be happy to merge this in.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub [https://github.com//pull/285#issuecomment-217926240]

@boazmohar
Copy link
Contributor Author

@jwittenbach looking over the blocks.py code, there is a dtype passed there:
blocks.py@map()

I haven't seen a test for it, do you want me to add one?

@jwittenbach
Copy link
Contributor

@boazmohar ah, I should have looked more closely. Yeah, if you want to add a test, that would be perfect!

@boazmohar
Copy link
Contributor Author

@jwittenbach Done, could you please have a look, I want Aaron to use this fix as well.
Thanks!

@jwittenbach
Copy link
Contributor

@boazmohar awesome. Looks like there are some merge conflicts. This is probably because some other changes have been made in the meantime. If you do a git pull upstream from this branch on your local machine, then you it will try to grab those changes. Any files where those changes clash with yours will show up when you do git status. Inside those files it will show you the conflict, and you just need to manually resolve it. Then do another comit and push.

@boazmohar
Copy link
Contributor Author

@jwittenbach sorry about the mess, should work now.

@jwittenbach
Copy link
Contributor

Looks good to me. Thanks @boazmohar!

@jwittenbach jwittenbach merged commit 1600547 into thunder-project:master May 9, 2016
@boazmohar boazmohar deleted the dtype_fix branch May 9, 2016 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dtype propogation in images.map() operation
2 participants