-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dtype to images.map #285
Conversation
Added dtype to series as well. |
@boazmohar this is looking great. Any chance you could add the same functionality to |
Sure I will do it later today. Thanks, — |
@jwittenbach looking over the I haven't seen a test for it, do you want me to add one? |
@boazmohar ah, I should have looked more closely. Yeah, if you want to add a test, that would be perfect! |
@jwittenbach Done, could you please have a look, I want Aaron to use this fix as well. |
@boazmohar awesome. Looks like there are some merge conflicts. This is probably because some other changes have been made in the meantime. If you do a |
…ype_fix # Conflicts: # test/test_blocks.py
@jwittenbach sorry about the mess, should work now. |
Looks good to me. Thanks @boazmohar! |
fixes #284
Only adds the functionality for images object not for series.