Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix spark test on travis due to lack of py4j #315

Merged
merged 2 commits into from
May 23, 2016
Merged

fix spark test on travis due to lack of py4j #315

merged 2 commits into from
May 23, 2016

Conversation

boazmohar
Copy link
Contributor

@boazmohar boazmohar commented May 22, 2016 •
edited
Loading

fixes #306

@freeman-lab
Copy link
Member

Again, awesome for figuring this out! Do you mind trying one more thing: remove the line you added and change this line

export PYTHONPATH=$SPARK_HOME/python/lib/py4j-0.8.2.1-src.zip:$PYTHONPATH

to

export PYTHONPATH=$SPARK_HOME/python/lib/py4j-0.9-src.zip:$PYTHONPATH

@boazmohar
Copy link
Contributor Author

@freeman-lab Yep, working as well!

@freeman-lab
Copy link
Member

Terrific! Let's do it this way, only because Spark technically pins the version of py4j it depends on by bundling it, which is kinda awkward, but we should follow that pattern.

@freeman-lab freeman-lab merged commit 8a42a86 into thunder-project:master May 23, 2016
@boazmohar boazmohar deleted the fix_travis_spark_py4j branch May 23, 2016 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spark tests on travis
2 participants
@boazmohar @freeman-lab