Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushes all map functionality up to Base #336

Closed
wants to merge 1 commit into from

Conversation

jwittenbach
Copy link
Contributor

No description provided.

@jwittenbach
Copy link
Contributor Author

@freeman-lab This was something that I had mentioned doing a while back. It came up presently because I wanted the value_shape argument in map to avoid the shape/dtype check in thunder-regression. However, it wasn't actually exposed on Series and was exposed by a different name (dims) on Images. So I figured I might as well just do it.

The only thing that is slightly awkward is that you can now no longer set the index for Series during the map, since that doesn't extend to Images. I handled this by replacing all instances with the pattern:

return series.map(f, index=index)

with

result = series.map(f)
result.index = index
return result

which doesn't seem so bad.

@jwittenbach
Copy link
Contributor Author

After offline conversation with @freeman-lab, decided to solve this in a slightly different fashion: #337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant