-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds reshaping functions to Images and Series #343
Conversation
@freeman-lab: I want to use this to make the handling of non-2D arrays nice and straight-forward in Thunder Factorization. Seemed general enough to include directly in Thunder. Thoughts? |
Cool, seems reasonable, is this the only case where the thunder API directly references
Other ideas? |
Yeah, I also thought about just calling it |
raise ValueError("Total number of series elements must remain unchanged") | ||
|
||
newshape = shape + (self.shape[-1], ) | ||
return self._constructor(self.values.reshape(newshape)).__finalize__(self) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be self.keys.reshape
right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh sorry, nevermind, this is correct, i was confused
@freeman-lab updated things to reflect our conversation yesterday...both |
Nice @jwittenbach , this looks great! Merging in. |
implements #335 for
Series
and a corresponding function forImages