Skip to content

Commit

Permalink
This is an automated cherry-pick of pingcap#45903
Browse files Browse the repository at this point in the history
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
  • Loading branch information
qw4990 authored and ti-chi-bot committed Aug 8, 2023
1 parent 74abc22 commit 9d478de
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 0 deletions.
1 change: 1 addition & 0 deletions parser/lexer.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ func (s *Scanner) reset(sql string) {
s.stmtStartPos = 0
s.inBangComment = false
s.lastKeyword = 0
s.identifierDot = false
}

func (s *Scanner) stmtText() string {
Expand Down
33 changes: 33 additions & 0 deletions parser/parser_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7192,3 +7192,36 @@ func TestTTLTableOption(t *testing.T) {

RunTest(t, table, false)
}
<<<<<<< HEAD
=======

func TestIssue45898(t *testing.T) {
p := parser.New()
p.ParseSQL("a.")
stmts, _, err := p.ParseSQL("select count(1) from t")
require.NoError(t, err)
var sb strings.Builder
restoreCtx := NewRestoreCtx(DefaultRestoreFlags, &sb)
sb.Reset()
stmts[0].Restore(restoreCtx)
require.Equal(t, "SELECT COUNT(1) FROM `t`", sb.String())
}

func TestMultiStmt(t *testing.T) {
p := parser.New()
stmts, _, err := p.Parse("SELECT 'foo'; SELECT 'foo;bar','baz'; select 'foo' , 'bar' , 'baz' ;select 1", "", "")
require.NoError(t, err)
require.Equal(t, len(stmts), 4)
stmt1 := stmts[0].(*ast.SelectStmt)
stmt2 := stmts[1].(*ast.SelectStmt)
stmt3 := stmts[2].(*ast.SelectStmt)
stmt4 := stmts[3].(*ast.SelectStmt)
require.Equal(t, "'foo'", stmt1.Fields.Fields[0].Text())
require.Equal(t, "'foo;bar'", stmt2.Fields.Fields[0].Text())
require.Equal(t, "'baz'", stmt2.Fields.Fields[1].Text())
require.Equal(t, "'foo'", stmt3.Fields.Fields[0].Text())
require.Equal(t, "'bar'", stmt3.Fields.Fields[1].Text())
require.Equal(t, "'baz'", stmt3.Fields.Fields[2].Text())
require.Equal(t, "1", stmt4.Fields.Fields[0].Text())
}
>>>>>>> 7bd16817954 (parser: reset `lexer.identifierDot` correctly when reusing parsers (#45903))

0 comments on commit 9d478de

Please sign in to comment.