-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add support for Poetry 1.2.0 and above (including 1.5.1), deprecate support for Python 3.6 #28
Conversation
…e, and package updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works and the changes are very simple. I hope this gets merged soon.
I think I understand why Tiangolo gave up on this project. importlib.metadata.version does this without any plugins required. Poetry uses it too. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
===========================================
- Coverage 100.00% 97.50% -2.50%
===========================================
Files 2 2
Lines 160 160
===========================================
- Hits 160 156 -4
- Misses 0 4 +4
☔ View full report in Codecov by Sentry. |
Thanks a lot @mbeacom! 🚀 And thanks everyone for the comments here. I updated a couple of extra packages to be able to run the tests locally and tweaked a couple of extra things. I'm not sure why Codecov is reporting some lines as not reached despite the tests that check for that exact output are passing. But anyway, I plan on moving away from Codecov, so that's fine for now. |
The goal of this PR is to resolve issues documented in #27 and compatibility issues mentioned in #25.
This PR resolves:
module_name
inpoetry.utils.helpers@module_name
which is now only available viapoetry.core.utils.helpers@module_name
set_version
as it was recently removed and rewritten to handle hashing under poetry.core'sProjectPackage._set_version(version, pretty_version)
Additionally, this PR updates some dependencies to allow
pytest
to execute under Python 3.10.Tests are passing with the provided changes.
Related to #27 and #25 (probably fixes them)