Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove shadowing of gRPC and netty #671

Closed
iosmanthus opened this issue Nov 23, 2022 · 0 comments · Fixed by #781
Closed

Remove shadowing of gRPC and netty #671

iosmanthus opened this issue Nov 23, 2022 · 0 comments · Fixed by #781
Labels
type/bug Something isn't working

Comments

@iosmanthus
Copy link
Member

Bug Report

1. Describe the bug

We previously added some metrics into gRPC and netty, and introduced some shadowing files to https://github.com/tikv/client-java/tree/master/src/main/java/io. While upgrading the gRPC/netty, might be painful and can present subtle bugs because of the binary compatibility. We might remove the shadowing code and consider a less invasive way to observe the gRPC/netty.
@iosmanthus iosmanthus added the type/bug Something isn't working label Nov 23, 2022
This was referenced Nov 23, 2022
Closed
Closed
@iosmanthus iosmanthus mentioned this issue Mar 28, 2024
Merged
iosmanthus added a commit that referenced this issue Mar 28, 2024
@iosmanthus
[close #671] remove shadowing of netty && grpc (#781)
0af4384
jackjeyis pushed a commit to jackjeyis/client-java that referenced this issue Jun 3, 2024
@iosmanthus
[close tikv#671] remove shadowing of netty && grpc (tikv#781)
9eb11f7 
Signed-off-by: b.tian <b.tian@trip.com>
shiyuhang0 added a commit that referenced this issue Jun 4, 2024
@jackjeyis @iosmanthus @shiyuhang0
[close #774] Add TwoPhaseCommitter new Constructor contains executorS…
700fad0 
…ervice(#774) (#775)

* add TwoPhaseCommitter new Constructor contains executorService(#774)

Signed-off-by: b.tian <b.tian@trip.com>

* [close #671] remove shadowing of netty && grpc (#781)

Signed-off-by: b.tian <b.tian@trip.com>

* [close #782] bump grpc to 1.60.0 (#783)

Signed-off-by: b.tian <b.tian@trip.com>

* [close #774]remove redundant code

---------

Signed-off-by: b.tian <b.tian@trip.com>
Co-authored-by: b.tian <b.tian@trip.com>
Co-authored-by: iosmanthus <dengliming@pingcap.com>
Co-authored-by: shi yuhang <52435083+shiyuhang0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@iosmanthus