Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[to #763] Pick bug fixes of API v2 codec to master #769

Merged
merged 4 commits into from
Oct 7, 2023
Merged

[to #763] Pick bug fixes of API v2 codec to master #769

merged 4 commits into from
Oct 7, 2023

Conversation

pingyu
Copy link
Contributor

@pingyu pingyu commented Sep 24, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #763

Problem Description: decode EpochNotMatch should ignore invalid region

What is changed and how does it work?

Cherry pick from release-3.3.1.14:

Code changes

  • No.

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test

Side effects

  • NO side effects

Related changes

  • NO related changes

iosmanthus and others added 3 commits September 24, 2023 16:19
@iosmanthus @pingyu
[cherry-pick] ignore invalid region while decoding EpochNotMatch (tik…
82119e4 
…v#765)

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
@iosmanthus @pingyu
fix region out of keyspace (tikv#766)
eb0f111 
* fix region decoding

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

* add test for decodeRegion

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

* add more tests for decodeRegion

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>

---------

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
@pingyu
[to tikv#763] Complement v2 codec unit test cases (tikv#768)
950c871 
* complement v2 codec unit test cases.

Signed-off-by: Ping Yu <yuping@pingcap.com>

* fix fmt

Signed-off-by: Ping Yu <yuping@pingcap.com>

---------

Signed-off-by: Ping Yu <yuping@pingcap.com>
@pingyu pingyu changed the title [to #763] Pick v2 codec fix to master [to #763] Pick bug fixes of API v2 codec to master Sep 24, 2023
@codecov
Copy link

codecov bot commented Oct 7, 2023 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
.../org/tikv/common/apiversion/RequestKeyV2Codec.java 88.57% <100.00%> (+5.71%) ⬆️
...in/java/org/tikv/common/apiversion/CodecUtils.java 80.00% <0.00%> (ø)
.../org/tikv/common/operation/RegionErrorHandler.java 49.68% <40.00%> (-0.64%) ⬇️

... and 6 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@pingyu pingyu requested a review from iosmanthus October 7, 2023 08:11
@iosmanthus iosmanthus merged commit 533dbc2 into tikv:master Oct 7, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iosmanthus iosmanthus iosmanthus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

decode EpochNotMatch should ignore invalid region
2 participants
@pingyu @iosmanthus