make it possible to cross-compile for iOS and Android targets #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, LGTM, @overvenus PTAL |
|
@eranrund Seems you need to run |
Hoverbear
reviewed
Feb 13, 2019
| // We don't need to generate install targets. | ||
| config.define("gRPC_INSTALL", "false"); | ||
| // We don't need to build csharp target. | ||
| config.define("gRPC_BUILD_CSHARP_EXT", "false"); | ||
| // We don't need to build codegen target. | ||
| config.define("gRPC_BUILD_CODEGEN", "false"); | ||
| // We don't need to build benchmarks. | ||
| config.define("gRPC_BENCHMARK_PROVIDER", "none"); |
There was a problem hiding this comment.
Can this improve build times as well? 😍
There was a problem hiding this comment.
It does result in less unnecessary code being built :)
|
Done! |
Hoverbear
approved these changes
Feb 13, 2019
|
Restarted Travis failed build. |
|
Thanks for merging! Any idea when we could expect this in a release? |
|
What do you think @BusyJay? |
|
@overvenus Maybe we can schedule a release next week. Several bugs are fixed since 0.4.2. |
|
That would be awesome ^_^ |
overvenus
pushed a commit
that referenced
this pull request
Feb 15, 2019
|
Sweet. Thank you all for moving quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya,
This PR makes it possible to cross-compile this crate to Android and iOS, both simulator and real hardware. I have tested it and the resulting code works flawlessly (tested on iPhone 7, iPhone XS, Nexus6P, iPhone simulator and Android simulator).
Building for iOS is as simple as cargo build --target i386-apple-ios/x86_64-apple-ios/armv7-apple-ios armv7s-apple-ios/aarch64-apple-ios
Android is more complicated and requires a bunch of environment variables. For example, on my machine, this is what I used for aarch64-linux-android: