Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pd-ctl command to manipulate ServiceGCSafePoint #2786

Closed
overvenus opened this issue Aug 18, 2020 · 2 comments · Fixed by #2797
Closed

Add a pd-ctl command to manipulate ServiceGCSafePoint #2786

overvenus opened this issue Aug 18, 2020 · 2 comments · Fixed by #2797
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. status/TODO The issue will be done in the future. type/enhancement The issue or PR belongs to an enhancement.

Comments

@overvenus
Copy link
Member

Feature Request

Add a command to manipulate ServiceGCSafePoint, including list and delete.

Describe your feature request related problem

We find TiDB GC safepoint stops forwarding sometimes, and it turns out TiCDC's ServiceGCSafePoint stops it.
For now, there is no way to inspect ServiceGCSafePoint in PD, and it is hard to debug if it happens.

Describe the feature you'd like

$pd-ctl service-gc-safepoint list
$pd-ctl service-gc-safepoint delete xxx

Describe alternatives you've considered

No.

Teachability, Documentation, Adoption, Migration Strategy

N/A

@overvenus overvenus added type/enhancement The issue or PR belongs to an enhancement. component/pd-ctl labels Aug 18, 2020
@disksing
Copy link
Contributor

what is the execution logic of the command? Do we need to start an etcd client?

@overvenus
Copy link
Member Author

Yes, as etcd kv is the only API that could list all ServiceGCSafepoint. Or we could add a few HTTP APIs to list and delete.

@disksing disksing added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. status/TODO The issue will be done in the future. labels Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. status/TODO The issue will be done in the future. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants