*: add service gc safepoint commands #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus
commented
Aug 19, 2020
| @@ -0,0 +1,70 @@ | |||
| // Copyright 2017 TiKV Project Authors. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2017 TiKV Project Authors. | |
| // Copyright 2020 TiKV Project Authors. |
| @@ -0,0 +1,70 @@ | |||
| // Copyright 2017 TiKV Project Authors. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2017 TiKV Project Authors. | |
| // Copyright 2020 TiKV Project Authors. |
Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus
added
the
needs-cherry-pick-release-4.0
disksing
reviewed
Aug 20, 2020
server/api/router.go
Outdated
| @@ -208,6 +208,11 @@ func createRouter(ctx context.Context, prefix string, svr *server.Server) *mux.R | |||
| apiRouter.Handle("/debug/pprof/block", pprof.Handler("block")) | |||
| apiRouter.Handle("/debug/pprof/goroutine", pprof.Handler("goroutine")) | |||
|
|
|||
| // service GC safepoint API | |||
| serviceGCSafepointHandler := newServiceGCSafepointHandler(svr, rd) | |||
| apiRouter.HandleFunc("/servicegcsafepoint", serviceGCSafepointHandler.List).Methods("GET") | |||
server/core/storage.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| ssps := make([]*ServiceSafePoint, 0, len(keys)) |
rleungx
changed the title
Signed-off-by: Neil Shen <overvenus@gmail.com>
disksing
approved these changes
Aug 21, 2020
ti-srebot
approved these changes
Aug 21, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/pd
that referenced
this pull request
Aug 21, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #2813 |
ti-srebot
added a commit
that referenced
this pull request
Aug 21, 2020
ZenoTan
pushed a commit
to ZenoTan/pd
that referenced
this pull request
Aug 24, 2020
Signed-off-by: Neil Shen <overvenus@gmail.com> Signed-off-by: ZenoTan <zenotan1998@gmail.com>
jyz0309
pushed a commit
to jyz0309/pd
that referenced
this pull request
Aug 24, 2020
Signed-off-by: Neil Shen <overvenus@gmail.com>
jyz0309
pushed a commit
to jyz0309/pd
that referenced
this pull request
Aug 24, 2020
Signed-off-by: Neil Shen <overvenus@gmail.com>
15 tasks
15 tasks
This was referenced Mar 15, 2023
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add service gc safepoint commands. Resolve #2786
Tests
Code changes
Related changes
pingcap/docs/pingcap/docs-cn:Release note