-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schedule: add options to disable replica checker features #1140
Conversation
why need to do this change? |
@nolouch In some scenarios, we need PD to handle specific types of tasks as quickly as possible. These options allow us to control the process meticulously, rather than let PD decide what to do. |
server/schedule/replica_checker.go
Outdated
@@ -172,6 +176,10 @@ func (r *ReplicaChecker) checkDownPeer(region *core.RegionInfo) *Operator { | |||
} | |||
|
|||
func (r *ReplicaChecker) checkOfflinePeer(region *core.RegionInfo) *Operator { | |||
if !r.cluster.IsMakeUpOfflineReplicaEnabled() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems makeup
in here not very suitable. maybe check or replace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PTAL @nolouch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What have you changed? (required)
Add 5 new options to turn on/off features of replicaChecker:
What are the type of the changes (required)?
How has this PR been tested (required)?
Does this PR affect documentation (docs/docs-cn) update? (optional)
pingcap/docs-cn#796
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)