switch from juju/errors to pkg/errors #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/errors maintains a stack trace and its not slower
gregwebs
force-pushed
the
switch-errors-juju-to-pkg
branch
from
f17d52e
to
4c70deb
Compare
nolouch
pushed a commit
that referenced
this pull request
Aug 28, 2018
* switch from juju/errors to pkg/errors pkg/errors maintains a stack trace and its not slower * Gopkg changes for juju/errors -> pkg/errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (required)
switch from juju/errors to pkg/errors. pkg/errors maintains a stack trace and its not slower.
This was requested on the PR #1200
See these PRs:
juju/errorstopkg/errorspingcap/tidb#7151What are the type of the changes (required)?
Its quite possible that error messages given to clients will show up a little bit differently now. Its possible, but unlikely this would break a client since a string match will likely still work.
How has this PR been tested (required)?
make && make check && make test