Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: support manage the component configuration #1977

Closed
wants to merge 16 commits into from

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Nov 28, 2019

What problem does this PR solve?

Provide a way to manage components' configuration in the cluster.

What is changed and how it works?

This PR is a basic implementation.

Check List

Tests

  • Unit test

@rleungx rleungx added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2019
@rleungx rleungx changed the title support manage the component configuration config: support manage the component configuration Nov 28, 2019
@rleungx rleungx force-pushed the dynamic-config branch 3 times, most recently from 55a6b1b to 90bee20 Compare December 11, 2019 07:46
@codecov-io
Copy link

Codecov Report

Merging #1977 into master will decrease coverage by 0.9%.
The diff coverage is 55.83%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1977      +/-   ##
=========================================
- Coverage    77.7%   76.8%   -0.91%     
=========================================
  Files         179     181       +2     
  Lines       18407   19102     +695     
=========================================
+ Hits        14304   14671     +367     
- Misses       3022    3303     +281     
- Partials     1081    1128      +47
Impacted Files Coverage Δ
server/cluster/cluster.go 80.39% <100%> (+0.02%) ⬆️
client/metrics.go 100% <100%> (ø) ⬆️
pkg/typeutil/duration.go 78.94% <100%> (+2.47%) ⬆️
server/grpc_service.go 50.92% <13.92%> (-6.32%) ⬇️
client/config_client.go 43.86% <43.86%> (ø)
server/server.go 75.23% <46.82%> (-8.26%) ⬇️
server/core/storage.go 73.07% <60%> (-2.38%) ⬇️
server/config/config.go 82.05% <66.66%> (ø) ⬆️
server/config/component_config.go 80.14% <80.14%> (ø)
server/kv/etcd_kv.go 72.72% <0%> (-11.69%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13ea87a...90bee20. Read the comment docs.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants