Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: export GetLeaderAddr #1996

Merged
merged 1 commit into from
Dec 10, 2019
Merged

client: export GetLeaderAddr #1996

merged 1 commit into from
Dec 10, 2019

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Dec 9, 2019

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

Some tools need to access PD's HTTP API but cannot know which PD is current leader.

What is changed and how it works?

export GetLeaderAddr.

Check List

Tests

  • only export exsisted function.

Signed-off-by: disksing <i@disksing.com>
@disksing disksing added the component/client Client logic. label Dec 9, 2019
@disksing disksing added this to the v4.0.0-beta milestone Dec 9, 2019
@zyxbest
Copy link

zyxbest commented Dec 9, 2019

/run-all-tests

Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@overvenus overvenus added needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. status/can-merge Indicates a PR has been approved by a committer. labels Dec 10, 2019
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot
Copy link
Contributor

sre-bot commented Dec 10, 2019

/run-all-tests

@sre-bot sre-bot merged commit 5086f2e into tikv:master Dec 10, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 10, 2019

cherry pick to release-3.1 in PR #2001

@disksing disksing deleted the leader-addr branch December 10, 2019 03:45
sre-bot added a commit that referenced this pull request Dec 10, 2019
Signed-off-by: disksing <i@disksing.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/client Client logic. needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants