Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: use TopN #2009

Merged
merged 3 commits into from
Dec 13, 2019
Merged

statistics: use TopN #2009

merged 3 commits into from
Dec 13, 2019

Conversation

Luffbee
Copy link
Contributor

@Luffbee Luffbee commented Dec 11, 2019

What problem does this PR solve?

Close issue #1997 .

What is changed and how it works?

Replace TwoQueueCache with TopN.

Check List

Tests

  • Unit test

@Luffbee Luffbee added the component/schedule Scheduling logic. label Dec 11, 2019
@Luffbee Luffbee added this to the v4.0.0-beta milestone Dec 11, 2019
@Luffbee Luffbee assigned nolouch and lhy1024 and unassigned nolouch and lhy1024 Dec 11, 2019
@Luffbee Luffbee added the type/enhancement The issue or PR belongs to an enhancement. label Dec 11, 2019
@codecov-io
Copy link

codecov-io commented Dec 11, 2019

Codecov Report

Merging #2009 into master will decrease coverage by 0.39%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2009     +/-   ##
=========================================
- Coverage   77.77%   77.38%   -0.4%     
=========================================
  Files         180      180             
  Lines       18154    18152      -2     
=========================================
- Hits        14120    14047     -73     
- Misses       2972     3031     +59     
- Partials     1062     1074     +12
Impacted Files Coverage Δ
server/statistics/hot_peer.go 100% <100%> (ø) ⬆️
server/statistics/hot_peer_cache.go 88.53% <86.66%> (-1.1%) ⬇️
pkg/cache/cache.go 0% <0%> (-62.17%) ⬇️
pkg/cache/two_queue.go 66.66% <0%> (-11.12%) ⬇️
pkg/etcdutil/etcdutil.go 82.6% <0%> (-8.7%) ⬇️
server/schedulers/base_scheduler.go 60.86% <0%> (-8.7%) ⬇️
server/region_syncer/client.go 78.94% <0%> (-6.58%) ⬇️
server/schedulers/shuffle_hot_region.go 61.29% <0%> (-5.38%) ⬇️
server/tso/tso.go 77.37% <0%> (-2.92%) ⬇️
server/statistics/store.go 71.15% <0%> (-2.89%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1c9ad8...129c7e7. Read the comment docs.

Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest LGTM

server/statistics/hot_peer.go Show resolved Hide resolved
@nolouch
Copy link
Contributor

nolouch commented Dec 13, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 13, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 13, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 13, 2019

@Luffbee merge failed.

@Luffbee
Copy link
Contributor Author

Luffbee commented Dec 13, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 13, 2019

/run-all-tests

@sre-bot sre-bot merged commit f7f643c into tikv:master Dec 13, 2019
@Luffbee Luffbee deleted the use-topn branch December 13, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/schedule Scheduling logic. status/can-merge Indicates a PR has been approved by a committer. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants