filter: replace region.Clone in filter (#2794) #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot
added
component/scheduler
lhy1024
approved these changes
Aug 19, 2020
ti-srebot
added
status/LGT1
|
plz resolve the conflict. |
Yisaer
force-pushed
the
release-4.0-a0eba9bf473f
branch
from
cd55702
to
cb7e407
Compare
Signed-off-by: Song Gao <disxiaofei@163.com>
Yisaer
force-pushed
the
release-4.0-a0eba9bf473f
branch
from
f823d63
to
4c130de
Compare
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2801 +/- ##
============================================
Coverage 77.46% 77.47%
============================================
Files 206 206
Lines 22652 22674 +22
============================================
+ Hits 17547 17566 +19
- Misses 3789 3790 +1
- Partials 1316 1318 +2
Continue to review full report at Codecov.
|
ti-srebot
added
status/LGT2
|
/run-all-tests |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #2794 to release-4.0
Signed-off-by: Song Gao disxiaofei@163.com
What problem does this PR solve?
ref #2783
region.Clone consumes too much cpu resources.
What is changed and how it works?
replace region.Clone with a self-maintained clone function as FitRegion only need partial information of a region.
BenchmarkCloneRegionTest is using new clone method and BenchmarkCloneRegionTest2 is using region.Clone
$ go test -bench=. -run=none goos: darwin goarch: amd64 pkg: github.com/tikv/pd/server/schedule/filter BenchmarkCloneRegionTest-4 4356267 267 ns/op BenchmarkCloneRegionTest2-4 316604 3292 ns/op PASS ok github.com/tikv/pd/server/schedule/filter 2.555sCheck List
Tests
Related changes
Release note