-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tso: Fix Local tso alloactor become alloactor leader without pd leader knowing its dc-location #3134
Conversation
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically LGTM, could you please add a test for this feature then?
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
/merge |
@Yisaer: you cannot merge your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/prow-config repository. |
/merge |
Can merge label has been added. Git tree hash: 0743edebc1ce6125831caaa1c1b79e59d9f370bd
|
/rebase |
/run-all-tests |
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
4d68177
to
8685702
Compare
New changes are detected. Can merge label has been removed. |
/run-all-tests |
1 similar comment
/run-all-tests |
/run-all-tests |
/merge |
@Yisaer: you cannot merge your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/prow-config repository. |
…r knowing its dc-location (tikv#3134) Signed-off-by: longfangsong <longfangsong@icloud.com>
* tso: Fix Local tso alloactor become alloactor leader without pd leader knowing its dc-location (#3134) Signed-off-by: longfangsong <longfangsong@icloud.com> * persist to etcd Signed-off-by: longfangsong <longfangsong@icloud.com> * load on boot and change leader Signed-off-by: longfangsong <longfangsong@icloud.com> * Apply several suggestion from code review Signed-off-by: longfangsong <longfangsong@icloud.com> * extract getTTLUint and getTTLFloat Signed-off-by: longfangsong <longfangsong@icloud.com> * extract EtcdKVPutWithTTL Signed-off-by: longfangsong <longfangsong@icloud.com> * format with goimports Signed-off-by: longfangsong <longfangsong@icloud.com> * support leader-schedule-limit Signed-off-by: longfangsong <longfangsong@icloud.com> * add tests Signed-off-by: longfangsong <longfangsong@icloud.com> * support hot-region-schedule-limit & replica-schedule-limit & merge-schedule-limit Signed-off-by: longfangsong <longfangsong@icloud.com> * add integration test and fix a bug Signed-off-by: longfangsong <longfangsong@icloud.com> * cleanup tests Signed-off-by: longfangsong <longfangsong@icloud.com> * Apply some suggestions from code review Signed-off-by: longfangsong <longfangsong@icloud.com> * extract getTTLFloatOr Signed-off-by: longfangsong <longfangsong@icloud.com> * apply suggestions from code review Signed-off-by: longfangsong <longfangsong@icloud.com> * apply suggestions from code review Signed-off-by: longfangsong <longfangsong@icloud.com> * apply suggestions from code review Signed-off-by: longfangsong <longfangsong@icloud.com> * make TestConfigTTLAfterTransferLeader run Serial to prevent it affect TestScatterRegion Signed-off-by: longfangsong <longfangsong@icloud.com> * apply suggestions from code reviewing Signed-off-by: longfangsong <longfangsong@icloud.com> * apply suggestions in code review Signed-off-by: longfangsong <longfangsong@icloud.com> * make the testing time as little as possible Signed-off-by: longfangsong <longfangsong@icloud.com> Co-authored-by: Song Gao <disxiaofei@163.com> Co-authored-by: Ti Prow Robot <71242396+ti-community-prow-bot@users.noreply.github.com>
Signed-off-by: Song Gao disxiaofei@163.com
What problem does this PR solve?
fix #3124
ref pingcap/kvproto#688
What is changed and how it works?
During
allocatorLeaderLoop
, the Allocator should query the dcLocations from leader to be sured that the pd leader is aware of this dc-location.Check List
Tests
Release note