-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
security: Encrypt region boundary keys, Part 4 - KMS #3141
Merged
Merged
Changes from 52 commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
20c682d
Encrypt region boundary keys, Part 2 - server changes
b6f7ba0
update errno and config template
0bf0304
fix typo
23954db
fix tests
2bad0b9
fix tests
f88d26a
fix tests
6f6d93a
fix tests
928de26
address comment in #2931
9b6bcfd
fix loadRegion
bdd5de4
rename encryption_key_manager package
bbdb8ef
Merge branch 'master' into enc_server
90de5ef
fix lint
c16ecd8
fix lint
2428248
fix comments
ce83a42
fix comment
073f13e
use option pattern
c35f948
move loadRegion and saveRegion
06d8963
Merge branch 'master' into enc_server
551b3f9
revert changes
7051407
fix doc
7201c37
address comment
c9eb341
Merge branch 'master' into enc_server
39f147e
Merge remote-tracking branch 'origin/master' into enc_server
12f03c4
Merge branch 'master' into enc_server
f951278
Merge branch 'master' into enc_server
ee2e0cd
key manager
9e753b4
add test and refactor
a6d1359
make EncryptionKeysPath a const
103a612
fix region_crypter key manager nil check
e9d810d
save conflict test
eb5b6b1
sanity check keys revision
c97b672
kms
bc3f35f
test set ciphertextKey
b5456df
test set ciphertextKey
fcf3fe2
clone region only when needed
4f2332f
add test for config
763bdb3
Merge branch 'enc_server' of github.com:yiwu-arbug/pd into enc_server
df6cb01
Merge branch 'master' into enc_server
8f444ac
Merge branch 'enc_kms' of github.com:yiwu-arbug/pd into enc_kms
1d42e57
update errors
af90759
Merge branch 'enc_server' into enc_ekm
39583d2
Merge branch 'enc_ekm' into enc_kms
079c299
Merge branch 'master' into enc_kms
9cbc5ff
fix lint
813a8d9
fix lint
d585204
Merge branch 'master' into enc_kms
7cf9888
make errdoc
9a6020f
address comment
5a69760
Merge branch 'master' into enc_kms
0321a80
fix error type
312bb48
fix test
e90b370
Merge branch 'master' into enc_kms
7480d5d
Merge branch 'master' into enc_kms
f1d3380
Merge branch 'master' into enc_kms
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to add this to the helper?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used in the unit test to fake and check ciphertext_key.