This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
Safer string coercions #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
force-pushed
the
safer-strings
branch
from
53b7da3
to
143fef8
Compare
Previously, we blindly assume Ruby strings are UTF-8 and turn them into Rust Strings (which *are* assumed to be UTF-8). This is clearly unsafe so this commit adds some checks to cofirm that and generate type errors appropiately.
chancancode
force-pushed
the
safer-strings
branch
from
143fef8
to
faaa6b1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we blindly assume Ruby strings are UTF-8 and turn them into Rust Strings (which are assumed to be UTF-8). This is clearly unsafe so this commit adds some checks to cofirm that and generate type errors appropiately.