Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing off by one error in state_agg interpolate #465

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Fixing off by one error in state_agg interpolate #465

merged 1 commit into from
Jul 27, 2022

Conversation

WireBaron
Copy link
Contributor

Fixes #464

epgts
epgts reviewed Jul 11, 2022
View reviewed changes
Copy link
Contributor

@epgts epgts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test that fails without the fix?

@WireBaron WireBaron force-pushed the br/state_agg_interpolation_fix branch from fb4808f to 5c15cdc Compare July 22, 2022 22:40
@WireBaron WireBaron requested a review from epgts July 22, 2022 22:46
rtwalker
rtwalker reviewed Jul 25, 2022
View reviewed changes
Copy link
Contributor

@rtwalker rtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the test fails without this fix!

@WireBaron
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 27, 2022

Build succeeded:

@bors bors bot merged commit c7a5dd0 into main Jul 27, 2022
@bors bors bot deleted the br/state_agg_interpolation_fix branch July 27, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtwalker rtwalker rtwalker approved these changes

@thatzopoulos thatzopoulos thatzopoulos approved these changes

@epgts epgts epgts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

state_agg interpolation hits an error if the interpolated first state doesn't already exist in the agg
4 participants
@WireBaron @rtwalker @thatzopoulos @epgts