Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker image for pgx 0.5.0 #571

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Update Docker image for pgx 0.5.0 #571

merged 1 commit into from
Oct 17, 2022

Conversation

syvb
Copy link
Member

@syvb syvb commented Oct 7, 2022

pgx 0.5.0 just released! This PR updates the CI to have pgx 0.5.0 and adds pgx 0.5.0 to the $PATH instead of pgx 0.4.5.

This PR should be merged right before merging #547 so that the CI can pass on that PR before merging it.

@syvb syvb mentioned this pull request Oct 7, 2022
5 tasks
Copy link
Contributor

@epgts epgts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

docker/ci/setup.sh Outdated Show resolved Hide resolved
@syvb syvb marked this pull request as ready for review October 17, 2022 16:34
@syvb
Copy link
Member Author

syvb commented Oct 17, 2022

The CI passes on #571 with this PR's Docker image: https://github.com/timescale/timescaledb-toolkit/actions/runs/3266892912/jobs/5371291553

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 17, 2022

Build succeeded:

@bors bors bot merged commit 4546419 into main Oct 17, 2022
@bors bors bot deleted the sv/0.5-docker branch October 17, 2022 16:52
bors bot added a commit that referenced this pull request Oct 17, 2022
547: Upgrade to pgx 0.5.0 r=Smittyvb a=Smittyvb

Upgrades to pgx `0.5.0-beta.1` (0.5.0 will hopefully be released in 0-7 days). I originally tested on another branch with a lot of code commented out; this branch cherry picks the commits that fix errors but not the ones that comment code out.

To do:
- [x] Fix the three failing tests in `datum_utils.rs` (pgcentralfoundation/pgrx#740)
- [x] Remove workaround for lack of `Copy` on some types
- [x] Make update tester work in CI (#552)
- [x] Change pgx version from 0.5.0-beta.1 to 0.5.0
- [ ] Publish new CI docker image with pgx 0.5.0 right before merging (#571)

Future work:
- Replace `use pgx::*` with `use pgx::prelude::*`
- Use native pgx types instead of `crate::raw`
- Use `#[pg_aggregate]` instead of our own aggregate builder macro

Co-authored-by: Smitty <smitty@timescale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants