Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that pgx doesn't generate CREATE OR REPLACE FUNCTION #594

Merged
merged 1 commit into from
Oct 28, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tools/post-install/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,10 @@ fn add_version_to_install_script(
let module_path = format!("$libdir/timescaledb_toolkit-{}", current_version);

transform_file_to(&install_script, &versioned_script, |line| {
if line.contains("CREATE OR REPLACE FUNCTION") {
return line.replace("CREATE OR REPLACE FUNCTION", "CREATE FUNCTION");
}
assert!(
!line.contains("CREATE OR REPLACE FUNCTION"),
"pgx should not generate CREATE OR REPLACE in functions"
);
if line.contains("MODULE_PATHNAME") {
return line.replace("MODULE_PATHNAME", &module_path);
}
Expand Down