Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add experimental library for client-side use, with examples. #620

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Add experimental library for client-side use, with examples. #620

merged 1 commit into from
Nov 28, 2022

Conversation

epgts
Copy link
Contributor

@epgts epgts commented Nov 16, 2022

For issue #485.

@epgts epgts force-pushed the eg/client branch 3 times, most recently from 98cb978 to bd06303 Compare November 16, 2022 18:29
@epgts epgts marked this pull request as ready for review November 16, 2022 18:36
@rtwalker
Copy link
Contributor

This probably merits a CHANGELOG entry right?

@syvb syvb self-requested a review November 17, 2022 02:05
syvb
syvb reviewed Nov 17, 2022
View reviewed changes
docs/examples/tdigest.c Outdated Show resolved Hide resolved
@epgts
Copy link
Contributor Author

epgts commented Nov 17, 2022

This probably merits a CHANGELOG entry right?

Actually, I'm not sure it does. I think at this point we're just looking at seeing what one user thinks about it.

@davidkohn88 ?

@epgts epgts force-pushed the eg/client branch 3 times, most recently from a27d42c to a8f8e0b Compare November 18, 2022 00:22
WireBaron
WireBaron approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@WireBaron WireBaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as a proof of concept.

extension/src/tdigest.rs Outdated Show resolved Hide resolved
@epgts
Copy link
Contributor Author

epgts commented Nov 28, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 28, 2022

Build succeeded:

@bors bors bot merged commit ff562e1 into main Nov 28, 2022
@bors bors bot deleted the eg/client branch November 28, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syvb syvb syvb left review comments

@WireBaron WireBaron WireBaron approved these changes

@thatzopoulos thatzopoulos Awaiting requested review from thatzopoulos

@rtwalker rtwalker Awaiting requested review from rtwalker

@davidkohn88 davidkohn88 Awaiting requested review from davidkohn88

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@epgts @rtwalker @syvb @WireBaron