Ensure PostgreSQL 16 compatibility #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feikesteenbergen
force-pushed
the
feike/pg16
branch
from
0b86f83
to
8da9de7
Compare
feikesteenbergen
force-pushed
the
feike/pg16
branch
2 times, most recently
from
b5133dd
to
05a1557
Compare
feikesteenbergen
force-pushed
the
feike/pg16
branch
2 times, most recently
from
873fc9b
to
fdd214f
Compare
DateTimeParseError: PostgreSQL source code documents that we can pass null pointers here: > extra can be NULL if not needed for the particular dterr value. > [...] > If escontext points to an ErrorSaveContext node, that is filled instead > of throwing an error DecodeDateTime however does not allow us to pass a null pointer, reading the source code, it is expected that extra is not null. Therefore, in order for us to get this thing to compile, we create an empty DateTimeErrorExtra, which gets passed along.
feikesteenbergen
force-pushed
the
feike/pg16
branch
from
fdd214f
to
e534b12
Compare
|
The CI image was built here. We still need to merge that PR in the release build scripts repo. |
feikesteenbergen
force-pushed
the
feike/pg16
branch
8 times, most recently
from
2ac17db
to
ada77fa
Compare
To achieve this, we have had to change quite a few things: Explicitly list our Docker Image builds The logic in the json was pretty complex, by using more yamls, and lists we hope to achieve a workflow that is easier to inspect, reason with and adapt. We also need to reintroduce the difference between $PG_VERSIONS and $TSDB_PG_VERSIONS, as PostgreSQL 16 support is not yet available for TimescaleDB.
feikesteenbergen
force-pushed
the
feike/pg16
branch
from
3649524
to
7028fbe
Compare
|
I pushed commits to get the CI closer to passing - timescale/timescaledb#6077 broke some of the tests when it introduced a breaking change to TimescaleDB. |
|
bors r+ |
|
Merging this manually since the main bors instance is gone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTimeParseError: PostgreSQL source code documents that we can pass null pointers here:
DecodeDateTime however does not allow us to pass a null pointer, reading the source code, it is expected that extra is not null. Therefore, in order for us to get this thing to compile, we create an empty DateTimeErrorExtra, which gets passed along.