Skip to content

Commit

Permalink
Add CI check for loader changes
Browse files Browse the repository at this point in the history
Changes in the loader code require a restart of PostgreSQL during
upgrades. This check creates awareness of these changes and allows the
coordination of the update process early.
  • Loading branch information
jnidzwetzki committed Nov 30, 2023
1 parent 01a65d8 commit ddd0c29
Showing 1 changed file with 37 additions and 0 deletions.
37 changes: 37 additions & 0 deletions .github/workflows/loader-check.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
name: Check for loader changes
"on":
pull_request:
types: [opened, synchronize, reopened, edited]
jobs:
check_changelog_file:
name: Check for loader changes
runs-on: ubuntu-latest
steps:
- name: Checkout source
uses: actions/checkout@v3

- name: Check if the pull request touches the loader
shell: bash --norc --noprofile {0}
env:
BODY: ${{ github.event.pull_request.body }}
PR_NUMBER: ${{ github.event.pull_request.number }}
run: |
# Get the list of modified files in this pull request
files=$(gh pr view $PR_NUMBER --json files --jq '.files.[].path')
# Ignore loader changes if acknowledged
if echo "$BODY" | egrep -qsi "Acknowledge-check:[[:space:]]*loader-change"; then
exit 0
fi
# Check for loader changes
if echo "${files}" | grep -Eq "^src/loader/.+$"; then
echo "Warning The PR does change the loader. Therefore the upgrade to the next TimescaleDB"
echo "version requires a restart of PostgreSQL. Please coordinate the release with the"
echo "cloud team before merging this PostgreSQL."
echo
echo "After the release is corrdinate, add:"
echo "Acknowledge-check: loader-change"
echo "to the PR message to acknowledge this warning"
exit 1
fi

0 comments on commit ddd0c29

Please sign in to comment.