Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ChunkAppend, ConstraintAwareAppend child subplan #5181

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Fix ChunkAppend, ConstraintAwareAppend child subplan #5181

merged 1 commit into from
Jan 18, 2023

Conversation

sb230132
Copy link
Contributor

@sb230132 sb230132 commented Jan 16, 2023 •
edited
Loading

When TidRangeScan is child of ChunkAppend or ConstraintAwareAppend node, an
error is reported as "invalid child of chunk append: Node (26)". This patch
fixes the issue by recognising TidRangeScan as a valid child.

Fixes: #4872

@sb230132 sb230132 self-assigned this Jan 16, 2023
@codecov
Copy link

codecov bot commented Jan 16, 2023 •
edited
Loading

Codecov Report

Merging #5181 (df2a21b) into main (6aa3d6e) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5181      +/-   ##
==========================================
- Coverage   89.42%   89.40%   -0.03%     
==========================================
  Files         225      225              
  Lines       51693    51692       -1     
==========================================
- Hits        46228    46213      -15     
- Misses       5465     5479      +14
Impacted Files Coverage Δ
src/nodes/chunk_append/planner.c 93.29% <ø> (ø)
.../constraint_aware_append/constraint_aware_append.c 91.15% <ø> (ø)
src/loader/bgw_launcher.c 89.51% <0.00%> (-2.55%) ⬇️
src/loader/bgw_message_queue.c 86.36% <0.00%> (-2.28%) ⬇️
src/bgw/scheduler.c 84.91% <0.00%> (-0.52%) ⬇️
tsl/src/bgw_policy/job.c 87.28% <0.00%> (-0.05%) ⬇️
tsl/src/reorder.c 86.09% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aa3d6e...df2a21b. Read the comment docs.

@sb230132 sb230132 marked this pull request as ready for review January 16, 2023 06:12
@github-actions
Copy link

@mkindahl, @konskov: please review this pull request.

Powered by pull-review

@sb230132 sb230132 requested review from akuzm and removed request for konskov January 16, 2023 06:13
mkindahl
mkindahl reviewed Jan 16, 2023
View reviewed changes
Copy link
Contributor

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have typos in the commit message, please check.

test/expected/create_hypertable.out Outdated Show resolved Hide resolved
@sb230132 sb230132 force-pushed the chunkappend_subplan branch 2 times, most recently from ae4028a to d2ebef2 Compare January 16, 2023 10:25
mkindahl
mkindahl reviewed Jan 16, 2023
View reviewed changes
Copy link
Contributor

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the two missing paths. Have you checked that all three locations are reached using the test case provided and that you do not need to add more tests?

src/nodes/constraint_aware_append/constraint_aware_append.c Show resolved Hide resolved
src/nodes/constraint_aware_append/constraint_aware_append.c Show resolved Hide resolved
@sb230132
Copy link
Contributor Author

Thanks for adding the two missing paths. Have you checked that all three locations are reached using the test case provided and that you do not need to add more tests?

Added tests which covers all three locations.

@sb230132 sb230132 force-pushed the chunkappend_subplan branch 2 times, most recently from 3b2240d to 37126a4 Compare January 17, 2023 06:00
@sb230132 sb230132 changed the title Fix ChunkAppend child node Fix ChunkAppend, ConstraintAwareAppend child subplan Jan 17, 2023
mkindahl
mkindahl approved these changes Jan 17, 2023
View reviewed changes
tsl/test/expected/compression.out Outdated Show resolved Hide resolved
@sb230132 sb230132 force-pushed the chunkappend_subplan branch 2 times, most recently from a4759b2 to 102cf60 Compare January 17, 2023 09:51
@sb230132
Fix ChunkAppend, ConstraintAwareAppend child subplan
df2a21b 
When TidRangeScan is child of ChunkAppend or ConstraintAwareAppend node, an
error is reported as "invalid child of chunk append: Node (26)". This patch
fixes the issue by recognising TidRangeScan as a valid child.

Fixes: timescale#4872
@sb230132 sb230132 merged commit 9a2cbe3 into timescale:main Jan 18, 2023
@sb230132 sb230132 deleted the chunkappend_subplan branch January 18, 2023 13:00
sb230132 added a commit to sb230132/timescaledb that referenced this pull request Jan 18, 2023
@sb230132
Release 2.9.2
f93b1d2 
This release contains bug fixes since the 2.9.1 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* timescale#5180 Fix dist_cagg flaky test
* timescale#5170 Fix CAgg on CAgg variable bucket size validation
* timescale#5114 Fix issue with deleting data node and dropping database
* timescale#5172 Remove parallel safe from partialize_agg
* timescale#5162 Fix telemetry_stats test in PG15
* timescale#5130 Fix CAgg on CAgg variable bucket size validation
* timescale#5133 Fix CAgg on CAgg different column order
* timescale#5152 Fix adding column with NULL constraint
* timescale#5136 Fix SELECT from partial compressed chunks
* timescale#5181 Fix ChunkAppend, ConstraintAwareAppend child subplan
@sb230132 sb230132 mentioned this pull request Jan 18, 2023
Closed
sb230132 added a commit to sb230132/timescaledb that referenced this pull request Jan 18, 2023
@sb230132
Release 2.9.2
6e9f566 
This release contains bug fixes since the 2.9.1 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* timescale#5180 Fix dist_cagg flaky test
* timescale#5170 Fix CAgg on CAgg variable bucket size validation
* timescale#5114 Fix issue with deleting data node and dropping database
* timescale#5172 Remove parallel safe from partialize_agg
* timescale#5162 Fix telemetry_stats test in PG15
* timescale#5133 Fix CAgg on CAgg different column order on the original hypertable
* timescale#5152 Fix adding column with NULL constraint to compressed hypertable
* timescale#5136 Fix SELECT from partial compressed chunks
* timescale#5181 Fix ChunkAppend, ConstraintAwareAppend child subplan
sb230132 added a commit to sb230132/timescaledb that referenced this pull request Jan 19, 2023
@sb230132
Release 2.9.2
de3d8a7 
This release contains bug fixes since the 2.9.1 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* timescale#5180 Fix dist_cagg flaky test
* timescale#5170 Fix CAgg on CAgg variable bucket size validation
* timescale#5114 Fix issue with deleting data node and dropping database
* timescale#5172 Remove parallel safe from partialize_agg
* timescale#5162 Fix telemetry_stats test in PG15
* timescale#5133 Fix CAgg on CAgg different column order on the original hypertable
* timescale#5152 Fix adding column with NULL constraint to compressed hypertable
* timescale#5136 Fix SELECT from partial compressed chunks
* timescale#5181 Fix ChunkAppend, ConstraintAwareAppend child subplan
* timescale#5193 Fix repartition behavior when attaching data node
sb230132 added a commit to sb230132/timescaledb that referenced this pull request Jan 19, 2023
@sb230132
Release 2.9.2
d98009b 
This release contains bug fixes since the 2.9.1 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* timescale#5180 Fix dist_cagg flaky test
* timescale#5170 Fix CAgg on CAgg variable bucket size validation
* timescale#5114 Fix issue with deleting data node and dropping database
* timescale#5133 Fix CAgg on CAgg different column order on the original hypertable
* timescale#5152 Fix adding column with NULL constraint to compressed hypertable
* timescale#5181 Fix ChunkAppend, ConstraintAwareAppend child subplan
* timescale#5193 Fix repartition behavior when attaching data node
sb230132 added a commit to sb230132/timescaledb that referenced this pull request Jan 19, 2023
@sb230132
Release 2.9.2
a6d481e 
This release contains bug fixes since the 2.9.1 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* timescale#5180 Fix dist_cagg flaky test
* timescale#5170 Fix CAgg on CAgg variable bucket size validation
* timescale#5114 Fix issue with deleting data node and dropping database
* timescale#5133 Fix CAgg on CAgg different column order on the original hypertable
* timescale#5152 Fix adding column with NULL constraint to compressed hypertable
* timescale#5181 Fix ChunkAppend, ConstraintAwareAppend child subplan
* timescale#5193 Fix repartition behavior when attaching data node
@sb230132 sb230132 mentioned this pull request Jan 19, 2023
Merged
sb230132 added a commit to sb230132/timescaledb that referenced this pull request Jan 19, 2023
@sb230132
Fix
23a4563 
Release 2.9.2

This release contains bug fixes since the 2.9.1 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* timescale#5152 Fix adding column with NULL constraint to compressed hypertable
* timescale#5133 Fix CAgg on CAgg different column order on the original hypertable
* timescale#5114 Fix issue with deleting data node and dropping database
* timescale#5170 Fix CAgg on CAgg variable bucket size validation
* timescale#5180 Fix default data node availability status
* timescale#5181 Fix ChunkAppend, ConstraintAwareAppend child subplan
* timescale#5193 Fix repartition behavior when attaching data node
sb230132 added a commit to sb230132/timescaledb that referenced this pull request Jan 19, 2023
@sb230132
Release 2.9.2
e021164 
This release contains bug fixes since the 2.9.1 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* timescale#5114 Fix issue with deleting data node and dropping database
* timescale#5133 Fix CAgg on CAgg different column order on the original hypertable
* timescale#5152 Fix adding column with NULL constraint to compressed hypertable
* timescale#5170 Fix CAgg on CAgg variable bucket size validation
* timescale#5180 Fix default data node availability status
* timescale#5181 Fix ChunkAppend, ConstraintAwareAppend child subplan
* timescale#5193 Fix repartition behavior when attaching data node
sb230132 added a commit to sb230132/timescaledb that referenced this pull request Jan 20, 2023
@sb230132
Release 2.9.2
f679f01 
This release contains bug fixes since the 2.9.1 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* timescale#5114 Fix issue with deleting data node and dropping database
* timescale#5133 Fix CAgg on CAgg using different column order on the original hypertable
* timescale#5152 Fix adding column with NULL constraint to compressed hypertable
* timescale#5170 Fix CAgg on CAgg variable bucket size validation
* timescale#5180 Fix default data node availability status
* timescale#5181 Fix ChunkAppend and ConstraintAwareAppend with TidRangeScan child subplan
* timescale#5193 Fix repartition behavior when attaching data node
sb230132 added a commit to sb230132/timescaledb that referenced this pull request Jan 23, 2023
@sb230132
Release 2.9.2
913aeba 
This release contains bug fixes since the 2.9.1 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* timescale#5114 Fix issue with deleting data node and dropping the database on multi-node
* timescale#5133 Fix creating a CAgg on a CAgg where the time column is in a different order of the original hypertable
* timescale#5152 Fix adding column with NULL constraint to compressed hypertable
* timescale#5170 Fix CAgg on CAgg variable bucket size validation
* timescale#5180 Fix default data node availability status on multi-node
* timescale#5181 Fix ChunkAppend and ConstraintAwareAppend with TidRangeScan child subplan
* timescale#5193 Fix repartition behavior when attaching data node on multi-node
sb230132 added a commit to sb230132/timescaledb that referenced this pull request Jan 23, 2023
@sb230132
Release 2.9.2
cd38666 
This release contains bug fixes since the 2.9.1 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* timescale#5114 Fix issue with deleting data node and dropping the database on multi-node
* timescale#5133 Fix creating a CAgg on a CAgg where the time column is in a different order of the original hypertable
* timescale#5152 Fix adding column with NULL constraint to compressed hypertable
* timescale#5170 Fix CAgg on CAgg variable bucket size validation
* timescale#5180 Fix default data node availability status on multi-node
* timescale#5181 Fix ChunkAppend and ConstraintAwareAppend with TidRangeScan child subplan
* timescale#5193 Fix repartition behavior when attaching data node on multi-node
sb230132 added a commit that referenced this pull request Jan 23, 2023
@sb230132
Release 2.9.2
f211294 
This release contains bug fixes since the 2.9.1 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* #5114 Fix issue with deleting data node and dropping the database on multi-node
* #5133 Fix creating a CAgg on a CAgg where the time column is in a different order of the original hypertable
* #5152 Fix adding column with NULL constraint to compressed hypertable
* #5170 Fix CAgg on CAgg variable bucket size validation
* #5180 Fix default data node availability status on multi-node
* #5181 Fix ChunkAppend and ConstraintAwareAppend with TidRangeScan child subplan
* #5193 Fix repartition behavior when attaching data node on multi-node
sb230132 added a commit that referenced this pull request Jan 24, 2023
@sb230132
Release 2.9.2
4d432d8 
This release contains bug fixes since the 2.9.1 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* #5114 Fix issue with deleting data node and dropping the database on multi-node
* #5133 Fix creating a CAgg on a CAgg where the time column is in a different order of the original hypertable
* #5152 Fix adding column with NULL constraint to compressed hypertable
* #5170 Fix CAgg on CAgg variable bucket size validation
* #5180 Fix default data node availability status on multi-node
* #5181 Fix ChunkAppend and ConstraintAwareAppend with TidRangeScan child subplan
* #5193 Fix repartition behavior when attaching data node on multi-node
sb230132 added a commit that referenced this pull request Jan 24, 2023
@sb230132
Release 2.9.2
8481248 
This release contains bug fixes since the 2.9.1 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* #5114 Fix issue with deleting data node and dropping the database on multi-node
* #5133 Fix creating a CAgg on a CAgg where the time column is in a different order of the original hypertable
* #5152 Fix adding column with NULL constraint to compressed hypertable
* #5170 Fix CAgg on CAgg variable bucket size validation
* #5180 Fix default data node availability status on multi-node
* #5181 Fix ChunkAppend and ConstraintAwareAppend with TidRangeScan child subplan
* #5193 Fix repartition behavior when attaching data node on multi-node
sb230132 added a commit that referenced this pull request Jan 24, 2023
@sb230132
Release 2.9.2
fe5da04 
This release contains bug fixes since the 2.9.1 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* #5114 Fix issue with deleting data node and dropping the database on multi-node
* #5133 Fix creating a CAgg on a CAgg where the time column is in a different order of the original hypertable
* #5152 Fix adding column with NULL constraint to compressed hypertable
* #5170 Fix CAgg on CAgg variable bucket size validation
* #5180 Fix default data node availability status on multi-node
* #5181 Fix ChunkAppend and ConstraintAwareAppend with TidRangeScan child subplan
* #5193 Fix repartition behavior when attaching data node on multi-node
sb230132 added a commit that referenced this pull request Jan 24, 2023
@sb230132
Release 2.9.2
28e7987 
This release contains bug fixes since the 2.9.1 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* #5114 Fix issue with deleting data node and dropping the database on multi-node
* #5133 Fix creating a CAgg on a CAgg where the time column is in a different order of the original hypertable
* #5152 Fix adding column with NULL constraint to compressed hypertable
* #5170 Fix CAgg on CAgg variable bucket size validation
* #5180 Fix default data node availability status on multi-node
* #5181 Fix ChunkAppend and ConstraintAwareAppend with TidRangeScan child subplan
* #5193 Fix repartition behavior when attaching data node on multi-node
sb230132 added a commit that referenced this pull request Jan 24, 2023
@sb230132
Release 2.9.2
3314810 
This release contains bug fixes since the 2.9.1 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* #5114 Fix issue with deleting data node and dropping the database on multi-node
* #5133 Fix creating a CAgg on a CAgg where the time column is in a different order of the original hypertable
* #5152 Fix adding column with NULL constraint to compressed hypertable
* #5170 Fix CAgg on CAgg variable bucket size validation
* #5180 Fix default data node availability status on multi-node
* #5181 Fix ChunkAppend and ConstraintAwareAppend with TidRangeScan child subplan
* #5193 Fix repartition behavior when attaching data node on multi-node
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkindahl mkindahl mkindahl approved these changes

@svenklemm svenklemm svenklemm approved these changes

@akuzm akuzm Awaiting requested review from akuzm

Assignees

@sb230132 sb230132

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: "Invalid child of chunk" on specific ctid filtering
3 participants
@sb230132 @mkindahl @svenklemm