Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change bgw_main field length to BGW_MAXLEN #5345

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

jnidzwetzki
Copy link
Contributor

@jnidzwetzki jnidzwetzki commented Feb 17, 2023

The content of bgw_main is copied into BackgroundWorker.bgw_function_name, which has a length of BGW_MAXLEN. This patch ensures that the size of these fields has the same length.


Found by: #5340
Disable-check: force-changelog-changed

The content of bgw_main is copied into BackgroundWorker.
bgw_function_name, which has a length of BGW_MAXLEN. This patch ensures
that the size of these fields has the same length.
@jnidzwetzki jnidzwetzki enabled auto-merge (rebase) February 17, 2023 20:29
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #5345 (289a67c) into main (0963609) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5345      +/-   ##
==========================================
+ Coverage   90.71%   90.76%   +0.05%     
==========================================
  Files         225      225              
  Lines       52014    44965    -7049     
==========================================
- Hits        47183    40812    -6371     
+ Misses       4831     4153     -678     
Impacted Files Coverage Δ
src/bgw/scheduler.c 85.99% <100.00%> (-2.50%) ⬇️
tsl/src/nodes/frozen_chunk_dml/frozen_chunk_dml.c 0.00% <0.00%> (-84.45%) ⬇️
tsl/test/src/test_chunk_stats.c 42.85% <0.00%> (-49.74%) ⬇️
tsl/src/nodes/compress_dml/compress_dml.c 86.66% <0.00%> (-11.16%) ⬇️
src/chunk.c 89.18% <0.00%> (-4.57%) ⬇️
src/bgw_policy/chunk_stats.c 81.53% <0.00%> (-4.01%) ⬇️
tsl/test/src/remote/dist_commands.c 90.62% <0.00%> (-3.97%) ⬇️
tsl/src/partialize_finalize.c 92.03% <0.00%> (-3.91%) ⬇️
tsl/src/chunk.c 90.69% <0.00%> (-3.70%) ⬇️
src/nodes/chunk_append/transform.c 96.42% <0.00%> (-3.58%) ⬇️
... and 193 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jnidzwetzki jnidzwetzki merged commit 83fc20f into timescale:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants