Small improvements of bulk decompression #5772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkindahl, @konskov: please review this pull request.
|
Codecov Report
@@ Coverage Diff @@
## main #5772 +/- ##
==========================================
- Coverage 87.90% 87.86% -0.04%
==========================================
Files 239 239
Lines 55742 55787 +45
Branches 12350 12358 +8
==========================================
+ Hits 48999 49017 +18
- Misses 4849 4870 +21
- Partials 1894 1900 +6
... and 22 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
svenklemm
approved these changes
Jun 26, 2023
pmwkaa
approved these changes
Jul 5, 2023
* Restore default batch context size to fix a performance regression on sorted batch merge plans. * Support reverse direction. * Improve gorilla decompression by computing prefix sums of tag bitmaps during decompression.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do some cleanup and support decompression in the reverse direction.
In tsbench it improves the first/last queries, by using the old sizes for the per-batch memory context: https://grafana.ops.savannah-dev.timescale.com/d/fasYic_4z/compare-akuzm?orgId=1&var-branch=All&var-run1=2477&var-run2=2478&var-threshold=0.05
Disable-check: force-changelog-file