Bulk decompression: compute bitmap prefix sums #5914
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are more useful for Gorilla decompression and for nulls handling, and allow us to simplify the algorithms and have a small performance boost.
5 tasks
Codecov Report
@@ Coverage Diff @@
## main #5914 +/- ##
==========================================
- Coverage 87.15% 86.93% -0.23%
==========================================
Files 243 244 +1
Lines 55550 55813 +263
Branches 12269 12356 +87
==========================================
+ Hits 48417 48520 +103
- Misses 4837 4930 +93
- Partials 2296 2363 +67
... and 37 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefix sums are more useful for Gorilla decompression, and allow us to simplify the algorithms and get a small performance boost.