Backport to 2.13.x: #6529: Remove reindex_relation from recompression #6530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to reindex relation when compressing chunks. Recently we moved to inserting into indexes on compressed chunks in order to reduce locks necessary for the operation. Since recompression uses RowCompressor, it also started inserting tuples into indexes but we never removed the relation reindexing. This change removes the unnecessary reindex call. (cherry picked from commit 45bc8a0)
timescale-automation
added
the
is-auto-backport
|
This is going into 2.14 release |
auto-merge was automatically disabled
February 1, 2024 08:15
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated backport of #6529: Remove reindex_relation from recompression.
The original issue is #6524.
This PR will be merged automatically after all the relevant CI checks pass. If this fix should not be backported, or will be backported manually, just close this PR. You can use the backport branch to add your changes, it won't be modified automatically anymore.
For more details, please see the documentation
Original description
Remove reindex_relation from recompression
We used to reindex relation when compressing chunks. Recently we moved to inserting into indexes on compressed chunks in order to reduce locks necessary for the operation. Since recompression uses RowCompressor, it also started inserting tuples into indexes but we never removed the relation reindexing. This change removes the unnecessary reindex call.
Fixes#6524