Add ensure calls to CAgg validation function #6808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CAgg validation logic is quite complex. This PR adds two ensure() statements to the validation function to make it more clear (e.g., also for static code analyzers) that we expect a valid bucket function.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6808 +/- ##
==========================================
+ Coverage 80.06% 80.95% +0.88%
==========================================
Files 190 194 +4
Lines 37181 36855 -326
Branches 9450 9649 +199
==========================================
+ Hits 29770 29835 +65
- Misses 2997 3174 +177
+ Partials 4414 3846 -568 ☔ View full report in Codecov by Sentry. |
fabriziomello
approved these changes
Apr 7, 2024
mkindahl
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CAgg validation logic is quite complex. This PR adds two ensure() statements to the validation function to make it more clear (e.g., also for static code analyzers) that we expect a valid bucket function.
Disable-check: force-changelog-file