Use ignore words file with codespell #6821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkindahl
force-pushed
the
codespell-ignore-words-file
branch
from
27765d3
to
cb01cfc
Compare
jnidzwetzki
reviewed
Apr 11, 2024
jnidzwetzki
approved these changes
Apr 11, 2024
mkindahl
force-pushed
the
codespell-ignore-words-file
branch
from
cb01cfc
to
5394ce4
Compare
It is not possible to automatically backport pull requests that makes modifications to workflow files and since the codespell action has a hard-coded list of ignored words as options, this means that any changes to the ignored codespell words cannot be backported. This pull request fixes this by using a ignore words file instead, which means that adding new words does not require changing a workflow file and hence the pull requests can be automatically backported.
mkindahl
force-pushed
the
codespell-ignore-words-file
branch
from
5394ce4
to
abe9a4c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6821 +/- ##
==========================================
+ Coverage 80.06% 80.91% +0.84%
==========================================
Files 190 194 +4
Lines 37181 36927 -254
Branches 9450 9669 +219
==========================================
+ Hits 29770 29878 +108
- Misses 2997 3183 +186
+ Partials 4414 3866 -548 ☔ View full report in Codecov by Sentry. |
akuzm
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not possible to automatically backport pull requests that makes modifications to workflow files and since the codespell action has a hard-coded list of ignored words as options, this means that any changes to the ignored codespell words cannot be backported.
This pull request fixes this by using a ignore words file instead, which means that adding new words does not require changing a workflow file and hence the pull requests can be automatically backported.
Disable-check: force-changelog-file