Remove CAgg watermark cache #6823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since timescale#6325 we constify the watermark value of a CAgg during planning time. Therefore, the planner calls the watermark function only once. This PR removes the old code to cache the watermark value and speed up multiple calls of the watermark function.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6823 +/- ##
==========================================
+ Coverage 80.06% 80.85% +0.79%
==========================================
Files 190 194 +4
Lines 37181 36905 -276
Branches 9450 9664 +214
==========================================
+ Hits 29770 29841 +71
- Misses 2997 3193 +196
+ Partials 4414 3871 -543 ☔ View full report in Codecov by Sentry. |
fabriziomello
added
continuous_aggregate
tech-debt
fabriziomello
approved these changes
Apr 15, 2024
akuzm
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #6325 we constify the watermark value of a CAgg during planning time. Therefore, the planner calls the watermark function only once. This PR removes the old code to cache the watermark value and speed up multiple calls of the watermark function.
Tsbench does not show any CAgg related regressions: https://grafana.ops.savannah-dev.timescale.com/d/NdmLnOk4z/compare-benchmark-runs?orgId=1&var-branch=main&var-run1=3424&var-run2=3425&var-threshold=0.02
Disable-check: force-changelog-file