Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce release notes header template #6873

Merged

Conversation

fabriziomello
Copy link
Contributor

@fabriziomello fabriziomello commented Apr 29, 2024

This PR introduce the release notes header template using Jinja [1]. Also improved the script to merge changelogs to include the upcoming .unreleased/RELEASE_NOTES_HEADER.md.j2 where we'll actually write the release notes header for the next release.

Disable-check: force-changelog-file

@fabriziomello fabriziomello added release enhancement An enhancement to an existing feature for functionality labels Apr 29, 2024
@fabriziomello fabriziomello self-assigned this Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.98%. Comparing base (59f50f2) to head (620a137).
Report is 139 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6873      +/-   ##
==========================================
+ Coverage   80.06%   80.98%   +0.91%     
==========================================
  Files         190      198       +8     
  Lines       37181    37286     +105     
  Branches     9450     9734     +284     
==========================================
+ Hits        29770    30197     +427     
- Misses       2997     3191     +194     
+ Partials     4414     3898     -516     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabriziomello fabriziomello force-pushed the introduce_release_notes_template branch from 7b1870c to 72bb953 Compare April 29, 2024 18:20
@fabriziomello fabriziomello added this to the TimescaleDB 2.15.0 milestone Apr 29, 2024
@fabriziomello fabriziomello changed the title Introduce release notes template Introduce release notes header template Apr 29, 2024
This PR introduce the release notes header template using Jinja [1].
Also improved the script to merge changelogs to include the upcoming
.unreleased/RELEASE_NOTES_HEADER.md.j2 where we'll actually write the
release notes header for the next release.
@fabriziomello fabriziomello force-pushed the introduce_release_notes_template branch from 72bb953 to 620a137 Compare April 29, 2024 21:35
Copy link
Contributor

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text looks good for now but added some suggestions for future improvements.

Comment on lines +13 to +16
In addition, it includes these noteworthy features:
* feature 1
* feature 2
* feature N
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a flag in the release files which ones are major and should end up as highlighted.

echo
fi

echo_changelog '**Features**' '^Implements:'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we can have a separate "Major Feature" field or something similar as a separate section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something that we can improve in the future. In the current release process we always mention major features in the release notes header.

Comment on lines +9 to +11
This release contains performance improvements and bug fixes since
the {{ release_previous }} release. We recommend that you upgrade at the next
available opportunity.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text probably needs to be slightly different depending on whether it is a patch release or a minor release and whether there are urgent fixes, something like:

  • We recommend that you upgrade immediately
  • We recommend that you upgrade at earliest available opportunity
  • We recommend that you upgrade as next convenient opportunity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we can, but this is only a template file for reference. The unreleased release notes header will be placed in .unreleased/RELEASE_NOTES_HEADER.md.j2 where we'll really write the text that will be used for release PR and GH page. Have a look in other PR #6874.

@fabriziomello fabriziomello merged commit fc46eab into timescale:main Apr 30, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.15.0 enhancement An enhancement to an existing feature for functionality release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants