Fix accessor function cagg_get_bucket_function #6922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziomello
force-pushed
the
fix_cagg_get_bucket_function
branch
from
f71ad65
to
4d5e58f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6922 +/- ##
==========================================
+ Coverage 80.06% 80.87% +0.80%
==========================================
Files 190 199 +9
Lines 37181 37190 +9
Branches 9450 9702 +252
==========================================
+ Hits 29770 30078 +308
- Misses 2997 3234 +237
+ Partials 4414 3878 -536 ☔ View full report in Codecov by Sentry. |
fabriziomello
force-pushed
the
fix_cagg_get_bucket_function
branch
from
4d5e58f
to
a61f99f
Compare
fabriziomello
force-pushed
the
fix_cagg_get_bucket_function
branch
2 times, most recently
from
b4c8a66
to
92a6e19
Compare
akuzm
reviewed
May 17, 2024
akuzm
approved these changes
May 17, 2024
erimatnor
approved these changes
May 17, 2024
In timescale#6624 we refactored time_bucket catalog table to be more generic and introduced the `cagg_get_bucket_function` to inspect the query tree of a given Continuous Aggregate and return the time_bucket function oid. The problem with the implementation is we traverse the whole query tree looking for `FuncExpr` and in certain cases we can have two different `time_bucket` function definition but what matters is the correct and valid `time_bucket` function that is part of the `Query->groupClause`. Fixed it by inspecting only the `Query->groupClause` items looking for a valid time bucket `FuncExpr` and return it `Oid`.
fabriziomello
force-pushed
the
fix_cagg_get_bucket_function
branch
from
92a6e19
to
38e5c2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6624 we refactored time_bucket catalog table to be more generic and introduced the
cagg_get_bucket_functionto inspect the query tree of a given Continuous Aggregate and return the time_bucket function oid.The problem with the implementation is we traverse the whole query tree looking for
FuncExprand in certain cases we can have two differenttime_bucketfunction definition but what matters is the correct and validtime_bucketfunction that is part of theQuery->groupClause.Fixed it by inspecting only the
Query->groupClauseitems looking for a valid time bucketFuncExprand return itOid.Disable-check: force-changelog-file