Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move chunkwise aggregation into TSL part #7159

Merged
merged 12 commits into from
Aug 8, 2024
Merged

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented Jul 27, 2024

Its purpose is to enable vectorized aggregation, and it has to interact with DecompressChunk to build proper plans, both of which are TSL-only.

Disable-check: force-changelog-file

Its purpose is to enable vectorized aggregation, and it has to interact
with DecompressChunk to build proper plans, both of which are TSL-only.
Copy link

codecov bot commented Jul 27, 2024

Codecov Report

Attention: Patch coverage is 89.33333% with 24 lines in your changes missing coverage. Please review.

Project coverage is 81.70%. Comparing base (59f50f2) to head (fe95431).
Report is 275 commits behind head on main.

Files Patch % Lines
tsl/src/chunkwise_agg.c 89.57% 2 Missing and 20 partials ⚠️
src/planner/planner.c 66.66% 0 Missing and 1 partial ⚠️
tsl/src/planner.c 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7159      +/-   ##
==========================================
+ Coverage   80.06%   81.70%   +1.63%     
==========================================
  Files         190      204      +14     
  Lines       37181    38015     +834     
  Branches     9450     9855     +405     
==========================================
+ Hits        29770    31060    +1290     
+ Misses       2997     2985      -12     
+ Partials     4414     3970     -444     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akuzm akuzm marked this pull request as ready for review July 31, 2024 13:05
@svenklemm
Copy link
Member

There are quite a few test changes where we no longer push down aggregates

@akuzm
Copy link
Member Author

akuzm commented Jul 31, 2024

There are quite a few test changes where we no longer push down aggregates

Right, the Apache ones. I think it's OK, the purpose of implementing our own partitionwise aggregation was to support vectorized aggregation which is TSL-only anyway. And if people need chunkwise aggregation with Apache version, there is the standard PG optionenable_partitionwise_aggregate.

@svenklemm
Copy link
Member

dont think enable_partitionwise_aggregate works anymore for hypertables

@akuzm akuzm enabled auto-merge (squash) August 8, 2024 16:23
@akuzm akuzm merged commit 2290ec4 into timescale:main Aug 8, 2024
41 of 45 checks passed
@akuzm akuzm deleted the tsl-chunkwise branch August 8, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants